ci(php): Add PHP installation on prefer lowest with PHP 7.1. (#296)

.github/workflows/test.yaml

@@ -1,6 +1,12 @@
-name: CI
+name: Tests
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
 
 jobs:
   run:
@@ -19,19 +25,25 @@ jobs:
           php-version: ${{ matrix.php }}
           coverage: xdebug
           tools: composer:v2
-      - name: Install PHP 8 Dependencies
+      - name: Install PHP 7 Dependencies
         uses: nick-invision/retry@v1
         with:
           timeout_minutes: 5
           max_attempts: 5
-          command: composer update --no-interaction --no-progress --ignore-platform-req=php
-        if: "matrix.php >= 8"
-      - name: Install PHP 7 Dependencies
+          command: composer update --no-interaction --prefer-dist --no-progress
+        if: "matrix.php < 8 && matrix.php > 7.1"
+      - name: Install PHP 7 Dependencies lowest
         uses: nick-invision/retry@v1
         with:
           timeout_minutes: 5
           max_attempts: 5
-          command: composer update --no-interaction --prefer-dist --no-progress
-        if: "matrix.php < 8"
+          command: composer update --no-interaction --prefer-lowest --no-progress
+        if: "matrix.php == 7.1"
+      - name: Install PHP 8 Dependencies
+        uses: nick-invision/retry@v1
+        with:
+          timeout_minutes: 5
+          max_attempts: 5
+          command: composer update --no-interaction --no-progress --ignore-platform-req=php
+        if: "matrix.php >= 8"
       - run: vendor/bin/phpunit --coverage-text
-

tests/Ups/Tests/QuantumViewTest.php

@@ -48,7 +48,7 @@ public function testGetSubscription()
         $this->assertObjectHasAttribute('Type', $events->offsetGet(0));
 
         // Test bookmarks
-        $this->assertIsBool($quantumView->hasBookmark());
+        $this->assertTrue(\is_bool($quantumView->hasBookmark()));
     }
 
     public function testSubscriptionContext()

tests/Ups/Tests/SimpleAddressValidationTest.php

@@ -5,14 +5,15 @@
 use Exception;
 use PHPUnit\Framework\TestCase;
 use Ups;
+use Ups\Entity\Address;
 
 class SimpleAddressValidationTest extends TestCase
 {
     public function testCreateRequest()
     {
         $validator = new Ups\SimpleAddressValidation();
 
-        $address = new \Ups\Entity\Address();
+        $address = new Address();
         $address->setStateProvinceCode('NY');
         $address->setCity('NYork');
         $address->setCountryCode('US');
@@ -36,21 +37,21 @@ public function testResponse()
         $validator = new Ups\SimpleAddressValidation();
         $validator->setRequest($request = new RequestMock(null, '/SimpleAddressValidation/Response1.xml'));
 
-        $address = new \Ups\Entity\Address();
+        $address = new Address();
         $address->setStateProvinceCode('NY');
         $address->setCity('NYork');
         $address->setCountryCode('US');
         $address->setPostalCode('10118');
         $result = $validator->validate($address);
 
         // Test response
-        $this->assertIsArray($result);
+        $this->assertTrue(is_array($result));
         $this->assertCount(6, $result);
 
         $first = $result[0];
         $this->assertInstanceOf('stdClass', $first);
         $this->assertEquals(1, $first->Rank);
-        $this->assertIsString($first->Quality);
+        $this->assertTrue(is_string($first->Quality));
         $this->assertEquals('0.9875', $first->Quality);
         $this->assertInstanceOf('stdClass', $first->Address);
         $this->assertEquals('NEW YORK', $first->Address->City);
@@ -61,7 +62,7 @@ public function testResponse()
         $last = $result[5];
         $this->assertInstanceOf('stdClass', $last);
         $this->assertEquals(6, $last->Rank);
-        $this->assertIsString($last->Quality);
+        $this->assertTrue(is_string($first->Quality));
         $this->assertEquals('0.9875', $last->Quality);
         $this->assertInstanceOf('stdClass', $last->Address);
         $this->assertEquals('NYC', $last->Address->City);

tests/Ups/Tests/TimeInTransitTest.php

@@ -11,12 +11,13 @@
 use Ups\Entity\ShipmentWeight;
 use Ups\Entity\TimeInTransitRequest;
 use Ups\Entity\UnitOfMeasurement;
+use Ups\TimeInTransit;
 
 class TimeInTransitTest extends TestCase
 {
     public function testCreateRequest()
     {
-        $tit = new Ups\TimeInTransit();
+        $tit = new TimeInTransit();
         $tit->setRequest($request = new RequestMock());
 
         $data = new TimeInTransitRequest();
@@ -82,7 +83,7 @@ public function testCreateRequest()
 
     public function testRequest()
     {
-        $tit = new Ups\TimeInTransit();
+        $tit = new TimeInTransit();
         $tit->setRequest($request = new RequestMock(null, '/TimeInTransit/Response1.xml'));
         $times = $tit->getTimeInTransit(new TimeInTransitRequest());
 
@@ -93,7 +94,7 @@ public function testRequest()
         $this->assertInstanceOf('\Ups\Entity\ShipmentWeight', $times->ShipmentWeight);
         $this->assertInstanceOf('\Ups\Entity\Charges', $times->InvoiceLineTotal);
         $this->assertInstanceOf('\Ups\Entity\ServiceSummary', $times->ServiceSummary[0]);
-        $this->assertIsString($times->Disclaimer);
+        $this->assertTrue(is_string($times->Disclaimer));
         $this->assertObjectHasAttribute('PickupDate', $times);
         $this->assertObjectHasAttribute('MaximumListSize', $times);
         $this->assertObjectHasAttribute('ServiceSummary', $times);
@@ -102,7 +103,7 @@ public function testRequest()
 
     public function testRequestOddCharacterParse()
     {
-        $tit = new Ups\TimeInTransit();
+        $tit = new TimeInTransit();
         $tit->setRequest($request = new RequestMock(null, '/TimeInTransit/Response2.xml'));
         $times = $tit->getTimeInTransit(new TimeInTransitRequest());
 
@@ -113,7 +114,7 @@ public function testRequestOddCharacterParse()
         $this->assertInstanceOf('\Ups\Entity\ShipmentWeight', $times->ShipmentWeight);
         $this->assertInstanceOf('\Ups\Entity\Charges', $times->InvoiceLineTotal);
         $this->assertInstanceOf('\Ups\Entity\ServiceSummary', $times->ServiceSummary[0]);
-        $this->assertIsString($times->Disclaimer);
+        $this->assertTrue(is_string($times->Disclaimer));
         $this->assertObjectHasAttribute('PickupDate', $times);
         $this->assertObjectHasAttribute('MaximumListSize', $times);
         $this->assertObjectHasAttribute('ServiceSummary', $times);
@@ -122,12 +123,11 @@ public function testRequestOddCharacterParse()
 
     public function testRequestOddCharacterCheckContent()
     {
-        $tit = new Ups\TimeInTransit();
+        $tit = new TimeInTransit();
         $tit->setRequest($request = new RequestMock(null, '/TimeInTransit/Response2.xml'));
         $times = $tit->getTimeInTransit(new TimeInTransitRequest());
 
         // Test response
-
-        $this->assertStringContainsString('Ë', $times->TransitTo->PoliticalDivision3);
+        $this->assertNotFalse(strpos($times->TransitTo->PoliticalDivision3, 'Ë'));
     }
 }