-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: code generate instruction account structs #16
Open
sol-mocha
wants to merge
8
commits into
gagliardetto:main
Choose a base branch
from
sol-mocha:mohca/codegen-accounts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sol-mocha
changed the title
chore: code generate instruction account struct
feat: code generate instruction account struct
Feb 1, 2023
sol-mocha
changed the title
feat: code generate instruction account struct
feat: code generate instruction account structs
Feb 1, 2023
@gagliardetto wondering if you can give some insight into the open question I have in the PR description. Do you anticipate any issues with the new code in relation to optional accounts? |
sol-mocha
force-pushed
the
mohca/codegen-accounts
branch
from
February 1, 2023 03:44
219ba33
to
4454062
Compare
Here is a real life example using these changes. Its applied on the drip program idl. |
sol-mocha
commented
Feb 2, 2023
Hey @dcaf-mocha Sorry for the delay in getting back to you. Thanks for the PR! That's a great idea. From what I remember:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the code gen in
main.go
to create structs for instruction accounts, as well as a helper to populate said structs given the AccountMetaSlice in the instruction builder. This will allow devs to safely access instruction accounts in a readable way without having to write their own converters and types.Open Questions
Example
idl/examples/composite.json
now produces the following extra code