Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a concurrent safe Gaia logger for plugins. #213

Merged

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Sep 10, 2019

Deals with the first data race encountered during the investigating in #205.

@codecov-io
Copy link

Codecov Report

Merging #213 into master will decrease coverage by 0.07%.
The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #213      +/-   ##
=========================================
- Coverage   62.18%   62.1%   -0.08%     
=========================================
  Files          49      49              
  Lines        4046    4059      +13     
=========================================
+ Hits         2516    2521       +5     
- Misses       1116    1124       +8     
  Partials      414     414
Impacted Files Coverage Δ
plugin/plugin.go 69.4% <47.82%> (-3.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68f7c1...cdea80f. Read the comment docs.

@Skarlso Skarlso requested a review from michelvocks September 10, 2019 09:49
Copy link
Member

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Skarlso
Copy link
Member Author

Skarlso commented Sep 10, 2019

Also tested with workers.

Screenshot 2019-09-10 at 16 53 48

Screenshot 2019-09-10 at 16 53 44

Looks good! :)

@Skarlso Skarlso merged commit 4c6678f into gaia-pipeline:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants