fix: adjust clear flag of internal render target

galacean · Nov 21, 2024 · e252e1b · e252e1b
1 parent f9fc2c6
commit e252e1b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/packages/core/src/RenderPipeline/BasicRenderPipeline.ts b/packages/core/src/RenderPipeline/BasicRenderPipeline.ts
@@ -164,7 +164,10 @@ export class BasicRenderPipeline {
     rhi.activeRenderTarget(colorTarget, colorViewport, context.flipProjection, mipLevel, cubeFace);
     const clearFlags = camera.clearFlags & ~(ignoreClear ?? CameraClearFlags.None);
     const color = background.solidColor;
-    if (clearFlags !== CameraClearFlags.None) {
+
+    if (internalColorTarget) {
+      rhi.clearRenderTarget(camera.engine, CameraClearFlags.All, color);
+    } else if (clearFlags !== CameraClearFlags.None) {
       rhi.clearRenderTarget(camera.engine, clearFlags, color);
     }
 

diff --git a/packages/core/src/postProcess/PostProcessManager.ts b/packages/core/src/postProcess/PostProcessManager.ts
@@ -1,8 +1,9 @@
 import { PipelineUtils } from "../RenderPipeline/PipelineUtils";
 import { RenderContext } from "../RenderPipeline/RenderContext";
 import { Scene } from "../Scene";
+import { CameraClearFlags } from "../enums/CameraClearFlags";
 import { Material } from "../material";
-import { Shader } from "../shader";
+import { BlendFactor, BlendOperation, Shader } from "../shader";
 import { RenderTarget, Texture2D } from "../texture";
 import { BloomEffect, TonemappingEffect } from "./effects";
 
@@ -39,6 +40,14 @@ export class _PostProcessManager {
     const uberShader = Shader.find(_PostProcessManager.UBER_SHADER_NAME);
     const uberMaterial = new Material(scene.engine, uberShader);
     const depthState = uberMaterial.renderState.depthState;
+    const blendState = uberMaterial.renderState.blendState.targetBlendState;
+
+    blendState.enabled = true;
+    blendState.sourceColorBlendFactor = BlendFactor.SourceAlpha;
+    blendState.destinationColorBlendFactor = BlendFactor.OneMinusSourceAlpha;
+    blendState.sourceAlphaBlendFactor = BlendFactor.One;
+    blendState.destinationAlphaBlendFactor = BlendFactor.OneMinusSourceAlpha;
+    blendState.colorBlendOperation = blendState.alphaBlendOperation = BlendOperation.Add;
 
     depthState.enabled = false;
     depthState.writeEnabled = false;
@@ -67,6 +76,10 @@ export class _PostProcessManager {
       bloomEffect.onRender(context, srcTexture);
     }
 
+    this._uberMaterial.renderState.blendState.targetBlendState.enabled = !(
+      context.camera.clearFlags & CameraClearFlags.Color
+    );
+
     // Done with Uber, blit it
     PipelineUtils.blitTexture(engine, srcTexture, destTarget, 0, camera.viewport, this._uberMaterial);
   }