Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt physics experience and opt physics unit test #2420

Merged
merged 55 commits into from
Nov 28, 2024

refactor: opt code

f8dc9c4
Select commit
Loading
Failed to load commit list.
Merged

Opt physics experience and opt physics unit test #2420

refactor: opt code
f8dc9c4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 28, 2024 in 0s

67.10% (-0.13%) compared to 35f10e2

View this Pull Request on Codecov

67.10% (-0.13%) compared to 35f10e2

Details

Codecov Report

Attention: Patch coverage is 92.67327% with 74 lines in your changes missing coverage. Please review.

Project coverage is 67.10%. Comparing base (35f10e2) to head (f8dc9c4).
Report is 27 commits behind head on dev/1.4.

Files with missing lines Patch % Lines
packages/physics-lite/src/LiteDynamicCollider.ts 56.96% 34 Missing ⚠️
packages/physics-physx/src/PhysXPhysicsScene.ts 81.39% 8 Missing ⚠️
packages/core/src/physics/DynamicCollider.ts 95.94% 6 Missing ⚠️
packages/core/src/physics/joint/Joint.ts 96.73% 6 Missing ⚠️
packages/physics-physx/src/PhysXDynamicCollider.ts 91.89% 6 Missing ⚠️
packages/physics-lite/src/LitePhysicsScene.ts 86.48% 5 Missing ⚠️
packages/core/src/physics/joint/JointLimits.ts 95.65% 4 Missing ⚠️
...ages/physics-physx/src/shape/PhysXColliderShape.ts 60.00% 4 Missing ⚠️
...ysics-physx/src/shape/PhysXCapsuleColliderShape.ts 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           dev/1.4    #2420      +/-   ##
===========================================
- Coverage    67.22%   67.10%   -0.13%     
===========================================
  Files          895      897       +2     
  Lines        92094    93218    +1124     
  Branches      7309     7576     +267     
===========================================
+ Hits         61912    62550     +638     
- Misses       29937    30423     +486     
  Partials       245      245

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov