Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: omnipool fees rework #987

Open
wants to merge 86 commits into
base: master
Choose a base branch
from
Open

feat: omnipool fees rework #987

wants to merge 86 commits into from

Conversation

enthusiastmartin
Copy link
Contributor

@enthusiastmartin enthusiastmartin commented Jan 10, 2025 •
edited
Loading

This PR implements changes to dynamic fee and other omnipool fee adjustments:

  • Multiblock dynamic fee
  • Mint H20 for asset fee
  • Use part of protocol fee to buy HDX or transfer to treasury ( now we transfer, when buyback implemented, it will go there instead)
  • Remove imbalance

Note that PR is based on #910 PR, so that should be merged first.

  • Rebenchmark

Spec: https://www.notion.so/hydradx/Fee-adjustments-b2447f1f5d294d8d9b4b74e353f3c098

@enthusiastmartin
add zombienet to gitignore
6ea18c1
@enthusiastmartin
remove imbalance from omnipool
d159393
@enthusiastmartin
remove imbalance from math
c57af07
@enthusiastmartin
update math tests to remove imbalance references
091f8d9
@enthusiastmartin
fix omnipool pallet to reflect new math api
8554646
@enthusiastmartin
update versions
863299b
@enthusiastmartin
use approx for dynamic fee calculation
7288312
@enthusiastmartin
tests for new fee update
96282a5
@enthusiastmartin
use oracle decay factor
b537f66
@enthusiastmartin
simply calculation
1ed84b6
@enthusiastmartin
decayign
7db3368
@enthusiastmartin
Decay tests
2324449
@enthusiastmartin
remove old dynamic fee calculation
4e194f9
@enthusiastmartin
update comments
e6b3ef5
@enthusiastmartin
bump version
328c439
@enthusiastmartin
use new math in dynamic fees pallet
4d23faf
@enthusiastmartin
add current liquidity to math calculation
9d317a6
@enthusiastmartin
Merge branch 'unified_trade_events' into remove-imbalance
79037de
@enthusiastmartin
Merge branch 'remove-imbalance' into feat/adjust-dynamic-fee
f2c193e
@enthusiastmartin
remove transfer of lrna to hdx subpool
8c60ded
@enthusiastmartin
Merge branch 'remove-imbalance' into feat/adjust-dynamic-fee
70762cd
@enthusiastmartin
add minting
43e3ba8
@enthusiastmartin
Merge branch 'unified_trade_events' into remove-imbalance
28af450
@enthusiastmartin
Merge branch 'remove-imbalance' into feat/adjust-dynamic-fee
a3d82b7
@enthusiastmartin
add minting for selling lrna
33ca530
@enthusiastmartin
add burning fee
dc28c00
@enthusiastmartin
omnipool math tests
d1df07a
@enthusiastmartin
remove comments
d61172c
@enthusiastmartin
omnipool pallet tests
cb77135
@enthusiastmartin
Merge branch 'unified_trade_events' into remove-imbalance
0e58054
@enthusiastmartin enthusiastmartin requested review from mrq1911, dmoka, Roznovjak, martinfridrich and jak-pan and removed request for dmoka January 15, 2025 16:32
@enthusiastmartin enthusiastmartin marked this pull request as ready for review January 17, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrq1911 mrq1911 Awaiting requested review from mrq1911

@Roznovjak Roznovjak Awaiting requested review from Roznovjak

@dmoka dmoka Awaiting requested review from dmoka

@martinfridrich martinfridrich Awaiting requested review from martinfridrich

@jak-pan jak-pan Awaiting requested review from jak-pan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Omnipool dynamic fee adjustments
1 participant
@enthusiastmartin