Addresses comments

galadriel-ai · Apr 10, 2024 · 286d574 · 286d574
1 parent 791091a
commit 286d574
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/contracts/tasks/e2e.ts b/contracts/tasks/e2e.ts
@@ -29,35 +29,35 @@ task("e2e", "Runs all e2e tests")
       "Who is the president of USA?",
       hre,
     )
-    testResults["OpenAI gpt-4-turbo-preview"] = result.error.length ? result.error : "✅";
+    testResults["OpenAI gpt-4-turbo-preview"] = result.error || "✅";
     result = await runOpenAi(
       contractAddress,
       "gpt-3.5-turbo-1106",
       "Who is the president of USA?",
       hre,
     )
-    testResults["OpenAI gpt-3.5-turbo-1106"] = result.error.length ? result.error : "✅";
+    testResults["OpenAI gpt-3.5-turbo-1106"] = result.error || "✅";
     result = await runGroq(
       contractAddress,
       "llama2-70b-4096",
       "Who is the president of USA?",
       hre,
     )
-    testResults["Groq llama2-70b-4096"] = result.error.length ? result.error : "✅";
+    testResults["Groq llama2-70b-4096"] = result.error || "✅";
     result = await runGroq(
       contractAddress,
       "mixtral-8x7b-32768",
       "Who is the president of USA?",
       hre,
     )
-    testResults["Groq mixtral-8x7b-32768"] = result.error.length ? result.error : "✅";
+    testResults["Groq mixtral-8x7b-32768"] = result.error || "✅";
     result = await runGroq(
       contractAddress,
       "gemma-7b-it",
       "Who is the president of USA?",
       hre,
     )
-    testResults["gemma-7b-it mixtral-8x7b-32768"] = result.error.length ? result.error : "✅";
+    testResults["gemma-7b-it mixtral-8x7b-32768"] = result.error || "✅";
     result = await runTaskWithTimeout(
       "image_generation",
       {
@@ -66,7 +66,7 @@ task("e2e", "Runs all e2e tests")
       },
       hre,
     )
-    testResults["OpenAI image_generation"] = result.error.length ? result.error : "✅";
+    testResults["OpenAI image_generation"] = result.error || "✅";
     result = await runTaskWithTimeout(
       "web_search",
       {
@@ -75,7 +75,7 @@ task("e2e", "Runs all e2e tests")
       },
       hre,
     )
-    testResults["web_search"] = result.error.length ? result.error : "✅";
+    testResults["web_search"] = result.error || "✅";
     result = await runTaskWithTimeout(
       "code_interpreter",
       {
@@ -84,7 +84,7 @@ task("e2e", "Runs all e2e tests")
       },
       hre,
     )
-    testResults["code_interpreter"] = result.error.length ? result.error : "✅";
+    testResults["code_interpreter"] = result.error || "✅";
 
     // console.log(`Running "add_knowledge_base"`)
     // await runTaskWithTimeout(
@@ -105,7 +105,7 @@ task("e2e", "Runs all e2e tests")
       },
       hre,
     )
-    testResults["query_knowledge_base"] = result.error.length ? result.error : "✅";
+    testResults["query_knowledge_base"] = result.error || "✅";
     const totalTests = Object.keys(testResults).length;
     const passedTests = Object.values(testResults).filter(result => result === "✅").length;
     const failedTests = totalTests - passedTests;

diff --git a/contracts/tasks/e2eCron.ts b/contracts/tasks/e2eCron.ts
@@ -34,8 +34,8 @@ async function main(): Promise<void> {
     "--network", network
   ];
 
+  let previousResult = false;
   while (true) {
-    let previousResult = false;
     console.log(`Running e2e tests with `)
     previousResult = await runTests(command, args, slackWebHookUrl, previousResult)
     console.log(`Run done, sleeping for ${TIMEOUT_SECONDS} seconds`)