-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revises Markdown Pages and Reports #19226
base: dev
Are you sure you want to change the base?
Conversation
4e9b9f0
to
89ce70d
Compare
I suspect this is going in a different direction but I want to reiterate points I failed to make with workflow comments but that I think are important. We've been around for 20 years - twice as long as vega - we should assume these blobs will be in databases in 2044 IMO - we shouldn't be tied to particular JavaScript library choices and we should look at this from a language design and maintenance perspective. We should develop a syntax for the charts we want to support and have a compatibility layer.
There should be a testing framework that rapidly demonstrates all the charts so we can visually diff things and render them on the frontend or backend with different technologies. The goal should be sustainable, maintainable set of components and not exposing every feature of vega lite. Even if the syntax is exactly vega lite's syntax - which is totally fine and makes a lot of sense - I think we should validate it is a very strict subset we are confident could be rendered using some other technology (native D3, ggplot, plotnine, etc...). |
5f38e54
to
cbd9382
Compare
17c808f
to
ca2f9bc
Compare
…nside the popup, simplify disabled prop handling
0e664af
to
3f1593a
Compare
Very early draft, sketching out and exploring how Vega and other Visualizations can be added to our Markdown components. There is still a lot to do, particularly with regard to early preview, parameter replacement, tests, modularity, element resizing etc. The report/page editor requires a significant overhaul and there are many issues to be fixed, so no need for a review as of right now.
How to test the changes?
(Select all options that apply)
License