Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting masthead height in a theme #19581

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

ksuderman
Copy link
Contributor

@ksuderman ksuderman commented Feb 10, 2025

The AnVIL instance of Galaxy makes some UI changes that cannot be set in a theme, in particular the --masthead-height and --masthead-logo-height. This PR adds support for those two CSS variables as well as a sample AnVIL theme that makes use of them.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.0 milestone Feb 10, 2025
hover: transparent
active: "#00090e"
logo:
height: "1.8rem"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Overall this looks fine to me, but I would prefer masthead-logo-height to not be a theme variable, but rather derived as ratio of the masthead head height as you suggest above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now the height is optional and is only included in the sample theme until I can figure out how to get it to be recalculated. I was hoping @ElectronicBlueberry's suggestion would fix that, but I'm still seeing the value for --masthead-logo-height to be 2.5 * 0.6 and not 3.0 * 0.6 as it should be if it was using the masthead height as defined in the theme. Laila, do you have any suggestions?

@ksuderman
Copy link
Contributor Author

What I am trying to achieve is to get as close as possible to what if defined in AnVIL's Galaxy fork: https://github.com/galaxyproject/galaxy/compare/release_24.1...anvilproject:galaxy:release_24.1?expand=1#diff-1bd3a4e46a82fb1d44b3eb90e15598c39de297524b5cde9646f9189bccae8198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants