Split docker_cmd
#19604
Draft
Split docker_cmd
#19604
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for podman IT setups [it seems necessary](https://github.com/galaxyproject/galaxy/blob/a81c573f037b9389ff928864b30cfe46b2232727/config/job_conf.yml.interactivetools.podman#L32) to set an environment variable (`HOME`) for the podman call in the job script (we overwrite `HOME` for the job). Without this change the Popen call would fail with `no such file or directory: HOME="..."`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for podman IT setups it seems necessary to set an environment variable (
HOME) for the podman call in the job script (we overwriteHOMEfor the job).Without this change the Popen call would fail with
no such file or directory: HOME="..."We could use
shlex.split(..., posix=False)if we want (with posix=True the quotes around the env value are removed).Also fixes the example
podman_cmdin the example job config. Since it was wrong so far, @sveinugu wanted to double check if it is necessary in his setup.How to test the changes?
(Select all options that apply)
License