Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Add fastk_ktab_tar datatype required for fastk tool #19615

Open
wants to merge 1 commit into
base: release_24.2
Choose a base branch
from

Conversation

SaimMomin12
Copy link
Contributor

This PR adds a new dataype called fastk_ktab_tar as advised by @bernt-matthias in galaxyproject/tools-iuc#6750

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.0 milestone Feb 14, 2025
@mvdbeek
Copy link
Member

mvdbeek commented Feb 14, 2025

Do you need this to be tar ? Otherwise a directory subclass seems to make more sense ?

@bernt-matthias
Copy link
Contributor

Do you need this to be tar ?

Good point. Seems that there is a directory that we tar and untar, before and after the tool runs, respectively.

Out of interest: the directory datatype is stored internally as a zip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants