Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added few new functionalities to DIAMOND tool #5864

Merged
merged 20 commits into from
Feb 3, 2025

Conversation

SaimMomin12
Copy link
Contributor

Following functionalities are added to this PR

--swipe Performs exhaustive alignment against all database sequences

--soft-masking Performs soft-masking using softmasking either of method (none=default, seg, tantan)

--index-chunks Memory utilization functionality for number of chunks for index processing

--file-buffer-size Memory utilization functionality for file buffer size in bytes

Added --faster sensitivity mode

Updated and added additional query gencode options

Added few more tests for above added functionalities

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! First review inline.

tools/diamond/diamond.xml Outdated Show resolved Hide resolved
tools/diamond/diamond.xml Outdated Show resolved Hide resolved
tools/diamond/diamond.xml Outdated Show resolved Hide resolved
tools/diamond/diamond.xml Show resolved Hide resolved
tools/diamond/diamond.xml Outdated Show resolved Hide resolved
tools/diamond/macros.xml Show resolved Hide resolved
@bgruening
Copy link
Member

Can you also please take those changes over into this PR? https://github.com/galaxyproject/tools-iuc/pull/6262/files

@SaimMomin12
Copy link
Contributor Author

🎉 yay! The latest version indeed fixes all the bugs. I will now focus on checking and adding new parameters to the tool (if any)

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment. Cool! We can finally deprecate blast-p

@SaimMomin12
Copy link
Contributor Author

Yes, my next task would be estimation of memory requirements for TPV based on sequence lengths.

@SaimMomin12 SaimMomin12 requested a review from bgruening January 31, 2025 11:21
@bernt-matthias
Copy link
Contributor

bernt-matthias commented Jan 31, 2025

Lets add these here and merge

#6262 fixes #6170
#6710

@SaimMomin12
Copy link
Contributor Author

@RZ9082 Regarding #6710 If you like, i can add your changes to the current PR

@RZ9082
Copy link
Contributor

RZ9082 commented Feb 3, 2025

@RZ9082 Regarding #6710 If you like, i can add your changes to the current PR

Yes, Please.

tools/diamond/diamond.xml Outdated Show resolved Hide resolved
@SaimMomin12
Copy link
Contributor Author

Merging #5864 closes #6710 #6262 #5156

@SaimMomin12 SaimMomin12 requested a review from bgruening February 3, 2025 14:16
@bgruening bgruening merged commit 62db819 into galaxyproject:main Feb 3, 2025
13 checks passed
@bgruening
Copy link
Member

Merci!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants