-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added few new functionalities to DIAMOND tool #5864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! First review inline.
Can you also please take those changes over into this PR? https://github.com/galaxyproject/tools-iuc/pull/6262/files |
🎉 yay! The latest version indeed fixes all the bugs. I will now focus on checking and adding new parameters to the tool (if any) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment. Cool! We can finally deprecate blast-p
Yes, my next task would be estimation of memory requirements for TPV based on sequence lengths. |
Merci! |
Following functionalities are added to this PR
--swipe
Performs exhaustive alignment against all database sequences--soft-masking
Performs soft-masking using softmasking either of method (none=default, seg, tantan)--index-chunks
Memory utilization functionality for number of chunks for index processing--file-buffer-size
Memory utilization functionality for file buffer size in bytesAdded
--faster
sensitivity modeUpdated and added additional query gencode options
Added few more tests for above added functionalities