Update minimap2.xml #6707
Merged
Update minimap2.xml #6707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the --eqx optional parameter from samtools to minimap2
bgruening
approved these changes
Jan 29, 2025
Add new param -d (2 column more on output) for SyRi compatibility
bgruening
reviewed
Jan 31, 2025
tools/mummer4/show-coords.xml
Outdated
| @@ -32,24 +40,47 @@ | |||
| <option value="-q">Sort output by query IDs and coordinates (-q)</option> | |||
| <option value="-r">Sort output by reference IDs and coordinates (-r)</option> | |||
| </param> | |||
| <conditional name="format"> | |||
There was a problem hiding this comment.
Why do you need a conditional here? Can you not just use the boolean param.
There was a problem hiding this comment.
What do you think about this comment @gdroc ?
There was a problem hiding this comment.
I just updated the code as you advised me.
bgruening
reviewed
Jan 31, 2025
|
Sorry for this mistake, what do you advise me to do? Close this PR ? |
|
We can also work further on this PR I don't mind. Can you comment maybe on my comment for the conditional? |
bgruening
reviewed
Feb 3, 2025
| <actions> | ||
| <action name="column_names" type="metadata" default="[S1], [E1], [S2], [E2], [LEN 1], [LEN 2], [% IDY], [LEN R], [LEN Q], [COV R], [COV Q], [REF TAG], [QUERY TAG]" /> | ||
| </actions> | ||
| </data> | ||
| <data name="output_extend" format="tabular" from_work_dir="show-coords_extend.txt" label="${tool.name} on ${on_string} extend format)" > | ||
| <filter>direction is True</filter> |
There was a problem hiding this comment.
Maybe add also column_names here as in "output"?
bgruening
approved these changes
Feb 4, 2025
|
Thanks a lot! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the --eqx optional parameter from samtools to minimap2
fixes: #6698
FOR CONTRIBUTOR: