Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAL-4169 rename Activity tab to Posts #1980

Merged
merged 2 commits into from
Oct 2, 2023
Merged

GAL-4169 rename Activity tab to Posts #1980

merged 2 commits into from
Oct 2, 2023

Conversation

kaitoo1
Copy link
Collaborator

@kaitoo1 kaitoo1 commented Oct 2, 2023

Summary of Changes

Rename the Activity tab on user profiles to Posts, on web and mobile

Demo or Before/After Pics

  • If this is a new feature, include screenshots or recordings of the feature in action.
  • If this PR makes visual changes, include before and after screenshots.
Before After
CleanShot 2023-10-02 at 19 37 20@2x CleanShot 2023-10-02 at 19 24 56@2x
CleanShot 2023-10-02 at 19 38 16@2x CleanShot 2023-10-02 at 19 25 14@2x

Edge Cases

Deep link of [username]/posts -> mobile app. I found this doesn't work on main, so made a ticket to address separately

Testing Steps

Open a user profile on web and mobile and confirm the tab now says Posts

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 10:47am

@github-actions github-actions bot added the mobile label Oct 2, 2023
@github-actions github-actions bot added the web label Oct 2, 2023
@kaitoo1 kaitoo1 changed the title rename Activity tab to Posts GAL-4169 rename Activity tab to Posts Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Bundle Sizes

Compared against ee4e999

Route Size (gzipped) Diff
/[username]/posts 711.98 KB added
/[username]/activity no change removed

Dynamic import: No significant changes found

@Robinnnnn Robinnnnn merged commit 87a5fcc into main Oct 2, 2023
@Robinnnnn Robinnnnn deleted the kaito/activity-posts branch October 2, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants