enable SyncCreatorTokens for Existing Contracts #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against 67b71c6
|
Rohan-cp
changed the title
Robinnnnn
reviewed
Oct 19, 2023
| const track = useTrack(); | ||
| const handleCreatorRefreshContract = useCallback( | ||
| async (contractId: string) => { | ||
| track('Editor Sidebar: Clicked Sync Creator Tokens For Existing Contract'); |
There was a problem hiding this comment.
let's make sure to fix the tracking:
track('Editor Sidebar: Clicked Sync Creator Tokens For Existing Contract', {
id: 'Refresh Single Created Contract Button',
context: contexts.Editor,
})
Comment on lines
73
to
80
| selectedView={selectedView} | ||
| setSpamPreferenceForCollection={setSpamPreferenceForCollection} | ||
| /> | ||
| ) : shouldDisplayContractRefreshIcon ? ( | ||
| <RefreshContractIcon contractId={row.contractId} /> | ||
| ) : ( | ||
| <CollectionCount>{row.count}</CollectionCount> | ||
| )} |
There was a problem hiding this comment.
nit: i think there's a lot of logic going on here, could simplify to:
const rightContent = useMemo(() => {
if (selectedView === 'Created' && isMouseHovering) {
return <RefreshContractIcon contractId={row.contractId} />;
}
if (selectedView !== 'Created' && isMouseHovering) {
return (
<ToggleSpamIcon
row={row}
selectedView={selectedView}
setSpamPreferenceForCollection={setSpamPreferenceForCollection}
/>
);
}
return <CollectionCount>{row.count}</CollectionCount>;
}, [isMouseHovering, row, selectedView, setSpamPreferenceForCollection]);
...
// render
{rightContent}| }; | ||
|
|
||
| function AnimatedRefreshContractIcon({ contractId, onRefresh }: AnimatedRefreshContractIconProps) { | ||
| const { isSyncing, syncCreatedTokensForExistingContract } = useSyncTokenstActions(); |
| } | ||
| eventElementId="NftSelectorSyncCreatedTokensForContractButton" | ||
| eventName="Nft Selector SyncCreatedTokensForContractButton pressed" | ||
| eventContext={contexts.UserCollection} |
| if (!collectionContractId) { | ||
| return; | ||
| } | ||
| track('NFT Selector: Clicked Sync Creator Tokens For Existing Contract'); |
There was a problem hiding this comment.
same thing, let's make sure to track additional details: { id: Refresh Single Contract Button, context: contexts.Posts }
Robinnnnn
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
You can refresh collections of created tokens from
-web: NftSelector, Editor
-mobile: NftSelector
Demo Mobile
newehoqeoq.mov
Demo Web
Screen.Recording.2023-10-18.at.4.29.18.PM.MOV
Screen.Recording.2023-10-18.at.4.31.17.PM.MOV
Edge Cases
List any common edge cases that you have considered and tested.
Testing Steps
Can test locally with a creator
Checklist
Please make sure to review and check all of the following: