Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FollowBack button regression on mobile #2006

Merged
merged 7 commits into from
Oct 15, 2023
Merged

Conversation

Rohan-cp
Copy link
Collaborator

@Rohan-cp Rohan-cp commented Oct 9, 2023

Summary of Changes

Wrap the notification text and handle different size usernames for the SomeoneFollowedYouNotification

Demo or Before/After Pics

Before After
Screenshot 2023-10-10 at 3 31 43 AM Screenshot 2023-10-15 at 7 01 08 AM

Edge Cases

Screenshot 2023-10-15 at 7 01 25 AM Screenshot 2023-10-15 at 7 01 42 AM

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 10:55pm

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Bundle Sizes

Compared against 60398f4

Route: No significant changes found

Dynamic import: No significant changes found

@Rohan-cp Rohan-cp changed the title base FollowBack button regression on mobile Oct 9, 2023
@Rohan-cp Rohan-cp requested a review from Robinnnnn October 9, 2023 22:44
@Rohan-cp Rohan-cp enabled auto-merge (squash) October 15, 2023 22:50
@Rohan-cp Rohan-cp merged commit 703d5a4 into main Oct 15, 2023
6 checks passed
@Rohan-cp Rohan-cp deleted the rohan/follow-back-wrap branch October 15, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants