Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change comment keyboard layout #2024

Merged
merged 1 commit into from
Oct 18, 2023
Merged

change comment keyboard layout #2024

merged 1 commit into from
Oct 18, 2023

Conversation

kaitoo1
Copy link
Collaborator

@kaitoo1 kaitoo1 commented Oct 18, 2023

Summary of Changes

Change Comment Keyboard Layout so that "@" is immediately accessible

Demo or Before/After Pics

  • If this is a new feature, include screenshots or recordings of the feature in action.
  • If this PR makes visual changes, include before and after screenshots.
Before After

|
CleanShot 2023-10-18 at 14 54 51
|
CleanShot 2023-10-18 at 14 53 36
|

Edge Cases

Testing Steps

  • Verify the comment input looks like the after screenshot
  • verify other keyboards (like in the post composer) haven't changed

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 6:04am

@github-actions
Copy link

Bundle Sizes

Compared against a204c08

Route: No significant changes found

Dynamic import: No significant changes found

@kaitoo1 kaitoo1 merged commit eebab16 into main Oct 18, 2023
6 checks passed
@kaitoo1 kaitoo1 deleted the kaito/comment-keyboard-layout branch October 18, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants