remove full page loader from global app level boundary suspense #2028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR modifies the global app level boundary to allow disabling the Full Page Loader for specified paths.
This is so that we can avoid showing a full screen loader for content pages like the Features Posts page.
This change should only affect the Features Posts page and not other pages.
Demo or Before/After Pics
No loader on Posts Feature page:
https://github.com/gallery-so/gallery/assets/80802871/808fef71-b546-41c5-a65a-e96edb2dccf9
Loader still shows for Collection Page:
https://github.com/gallery-so/gallery/assets/80802871/720bb353-6e3c-4a8f-93d5-4e8f3d7a01fe
Loader still shows for User Page:
https://github.com/gallery-so/gallery/assets/80802871/b2981f62-3613-4326-ad5a-68acdabaf461
Loader still shows for Feed;
CleanShot.2023-10-18.at.17.49.15.mp4
Edge Cases
n/a
Testing Steps
go to /features/posts and verify there's no full page loader. the content should just appear.
go to other pages and verify that a loader is shown (assuming it is currently shown on prod)
Checklist
Please make sure to review and check all of the following: