Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove full page loader from global app level boundary suspense #2028

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

kaitoo1
Copy link
Collaborator

@kaitoo1 kaitoo1 commented Oct 18, 2023

Summary of Changes

This PR modifies the global app level boundary to allow disabling the Full Page Loader for specified paths.
This is so that we can avoid showing a full screen loader for content pages like the Features Posts page.

This change should only affect the Features Posts page and not other pages.

Demo or Before/After Pics

No loader on Posts Feature page:
https://github.com/gallery-so/gallery/assets/80802871/808fef71-b546-41c5-a65a-e96edb2dccf9

Loader still shows for Collection Page:
https://github.com/gallery-so/gallery/assets/80802871/720bb353-6e3c-4a8f-93d5-4e8f3d7a01fe

Loader still shows for User Page:
https://github.com/gallery-so/gallery/assets/80802871/b2981f62-3613-4326-ad5a-68acdabaf461

Loader still shows for Feed;

CleanShot.2023-10-18.at.17.49.15.mp4

Edge Cases

n/a

Testing Steps

go to /features/posts and verify there's no full page loader. the content should just appear.
go to other pages and verify that a loader is shown (assuming it is currently shown on prod)

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 8:55am

@github-actions
Copy link

Bundle Sizes

Compared against eebab16

Route: No significant changes found

Dynamic import: No significant changes found

@Robinnnnn Robinnnnn merged commit b7f16a6 into main Oct 18, 2023
6 checks passed
@Robinnnnn Robinnnnn deleted the kaito/boundary-suspense branch October 18, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants