Kaito/features external link #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against 2156cb6 Route: No significant changes found Dynamic import: No significant changes found |
Robinnnnn
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR modifies GalleryLinkNeedsVerification so that we don't show the confirmation popup on certain routes such as our content pages. Since we know and trust the external links displayed on those pages, we want to immediately open them in a new tab when the user clicks them, as opposed to confirming that they want to access that url.
Demo or Before/After Pics
no confirmation on Posts Feature page
CleanShot.2023-10-19.at.21.47.30.mp4
still show confirmation elsehwere
CleanShot.2023-10-19.at.21.47.17.mp4
Edge Cases
na
Testing Steps
go to /features/posts and click the mirror article url. it should not show a confrimation
go to the feed and click a url. it should show a confirmation
Checklist
Please make sure to review and check all of the following: