Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GAL-4436] notification regression #2045

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[GAL-4436] notification regression #2045

merged 1 commit into from
Oct 25, 2023

Conversation

Rohan-cp
Copy link
Collaborator

@Rohan-cp Rohan-cp commented Oct 23, 2023 •
edited
Loading

Summary of Changes

update styling of SomeoneCommentedOnYourPost notification to accommodate text and token preview correctly

Demo or Before/After Pics

Before After
Screenshot 2023-10-23 at 7 32 53 PM Screenshot 2023-10-23 at 7 27 44 PM
Before After
Screenshot 2023-10-23 at 7 36 14 PM Screenshot 2023-10-23 at 7 38 10 PM

Edge Cases

List any common edge cases that you have considered and tested.

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

@vercel
Copy link

vercel bot commented Oct 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 2:05pm

@github-actions github-actions bot added the web label Oct 23, 2023
@Rohan-cp Rohan-cp requested review from kaitoo1 and Robinnnnn October 23, 2023 14:03
@github-actions
Copy link

Bundle Sizes

Compared against 67b71c6

Route: No significant changes found

Dynamic import: No significant changes found

@Rohan-cp Rohan-cp changed the title notification regression [GAL-4436] notification regression Oct 23, 2023
@Robinnnnn Robinnnnn merged commit b56d8b3 into main Oct 25, 2023
@Robinnnnn Robinnnnn deleted the notifications-regression branch October 25, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robinnnnn Robinnnnn Robinnnnn approved these changes

@kaitoo1 kaitoo1 Awaiting requested review from kaitoo1

Assignees
No one assigned
Labels
web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rohan-cp @Robinnnnn