Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deeplink user profile specific tabs issue ❓ #2052

Closed
wants to merge 1 commit into from

Conversation

Rohan-cp
Copy link
Collaborator

@Rohan-cp Rohan-cp commented Oct 27, 2023

Summary of Changes

For some reason the correct tab will be highlighted in GalleryTabsContainer, but the underlying tab isn't properly selected in the useEffect (containerRef.current.jumpToTab(selectedRoute);)

Demo or Before/After Pics

  • If this is a new feature, include screenshots or recordings of the feature in action.
  • If this PR makes visual changes, include before and after screenshots.
Before After

Edge Cases

List any common edge cases that you have considered and tested.

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 8:50am

@github-actions
Copy link

Bundle Sizes

Compared against 5255e6f

Route: No significant changes found

Dynamic import: No significant changes found

@Robinnnnn Robinnnnn changed the title Deeplink user profile specific tabs issue Deeplink user profile specific tabs issue ❓ Nov 1, 2023
@Rohan-cp Rohan-cp closed this Jan 26, 2024
@Rohan-cp Rohan-cp deleted the deeplink-user-specific-tabs branch April 9, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant