-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not merge] Add all networks dropdown (web) #2354
Open
pvicensSpacedev
wants to merge
17
commits into
main
Choose a base branch
from
pato/add-all-networks-dropdown
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against 5ae8213 Route: No significant changes found Dynamic import: No significant changes found |
Robinnnnn
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apps/web/src/components/GalleryEditor/PiecesSidebar/AddWalletSidebar.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/GalleryEditor/PiecesSidebar/AddWalletSidebar.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/GalleryEditor/PiecesSidebar/PiecesSidebar.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/GalleryEditor/PiecesSidebar/PiecesSidebar.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/GalleryEditor/PiecesSidebar/PiecesSidebar.tsx
Outdated
Show resolved
Hide resolved
Robinnnnn
changed the title
Add all networks dropdown (web)
[do not merge] Add all networks dropdown (web)
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Added all networks option in web. Changed types to accomodate 'All Networks' which means we should modify it in mobile as well.
There is a refresh bug currently in mobile that sort of blocks it though.
Demo or Before/After Pics
Checklist
Please make sure to review and check all of the following: