[GAL-5166] fix to remove empty feed items #2378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against b1f834d Route: No significant changes found Dynamic import: No significant changes found |
Rohan-cp
commented
Mar 23, 2024
| return null; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
kind of a hacky fix but basically was trying to ignore the eventDataTypeGalleryInfoUpdatedFeedEventData because we don't have a component for it from this file so it would always be an empty item for this event type. I wanted to know if you had a better idea of how I could fix this @Robinnnnn! thanks
There was a problem hiding this comment.
sorry but why can't we just introduce a new component in the screenshot you provided?
Rohan-cp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo or Before/After Pics
Before
After (feed as per usual with empty item removed)
Edge Cases
List any common edge cases that you have considered and tested.
Testing Steps
Provide steps on how the reviewer can test the changes.
Checklist
Please make sure to review and check all of the following: