Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression where all chains are disabled for collected tab #2421

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

kaitoo1
Copy link
Collaborator

@kaitoo1 kaitoo1 commented Apr 10, 2024

Summary of Changes

fix regression where all chains are disabled for collected tab

Demo or Before/After Pics

Before

Non admin , collected tab
CleanShot 2024-04-10 at 18 43 31@2x

Non admin, created tab
CleanShot 2024-04-10 at 18 43 38@2x

After
Non admin, collected tab
CleanShot 2024-04-10 at 18 43 52@2x

Non admin, created tab
CleanShot 2024-04-10 at 18 44 02@2x

Same fix for nft selector dropdown
CleanShot 2024-04-10 at 18 45 26@2x

Edge Cases

  • is admin user
  • is not admin user

Testing Steps

  • log in as a non admin user

  • go to the editor or nft selector and select the network dropdown

  • you should be able to select any chain for the Collected tab

  • you should see a limited selection of chains for the Created tab

  • if you log in as an admin user you should see all chains enabled

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 9:49am

Copy link

Bundle Sizes

Compared against 2d4ebd9

Route: No significant changes found

Dynamic import: No significant changes found

@kaitoo1 kaitoo1 merged commit 475fe6a into main Apr 10, 2024
7 checks passed
@kaitoo1 kaitoo1 deleted the kaito/chain-enable-fix branch April 10, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant