Kaito/bottom sheet regression #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against f000929 Route: No significant changes found Dynamic import: No significant changes found |
Robinnnnn
reviewed
Apr 17, 2024
| @@ -98,11 +96,13 @@ export function ConnectedTokenAdmireList({ tokenId }: { tokenId: string }) { | |||
| ); | |||
|
|
|||
| return ( | |||
| // <View className="flex-grow h-full"> | |||
Robinnnnn
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixed regression where using navigation.push inside Bottom Sheets crashes the app.
also fixed regressions and issues with certain bottom sheets not opening, or having wrong heights.
Demo or Before/After Pics
CleanShot.2024-04-17.at.22.23.09.mp4
Edge Cases
Testing Steps
Go to a bottom sheet that has a list of users (ie shared followers list on user profile, or admires on a post)
Tap on a username in the bottom sheet list
you should be navigated to the user profile, without the app crashing
Test other bottom sheets in the app to ensure they open as expected
Checklist
Please make sure to review and check all of the following: