Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile screen skeleton loader #2438

Merged
merged 6 commits into from
Apr 26, 2024
Merged

profile screen skeleton loader #2438

merged 6 commits into from
Apr 26, 2024

Conversation

pvicensSpacedev
Copy link
Collaborator

Summary of Changes

  • Skeleton loaders for profile screen (web)
  • Also adding a key to Suspense makes it so it retriggers the actual boundary when navigating between same routes (form profile to profiel, ie. robin -> santa)

Demo or Before/After Pics

Screen.Recording.2024-04-24.at.17.31.55.mov

Edge Cases

List any common edge cases that you have considered and tested.

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ❌ Failed (Inspect) Apr 26, 2024 0:03am

@github-actions github-actions bot added the web label Apr 24, 2024
Copy link

github-actions bot commented Apr 24, 2024

Bundle Sizes

Compared against 19ff3a6

Route Size (gzipped) Diff
/[username] 349.55 KB +1.07 KB
/[username]/[collectionId] 355.79 KB +1.07 KB
/[username]/bookmarks 355.4 KB +1.07 KB
/[username]/followers 354.21 KB +1.07 KB
/[username]/galleries 373.97 KB +1.05 KB
/[username]/galleries/[galleryId] 352.74 KB +1.07 KB
/[username]/posts 444.73 KB +1.07 KB
/post/[postId] 403.19 KB +1.07 KB
Dynamic import Size (gzipped) Diff
../src/contexts/relay/network.ts -> persisted_queries.json 101.47 KB -1.43 KB

@Robinnnnn Robinnnnn merged commit f77743d into main Apr 26, 2024
6 of 7 checks passed
@Robinnnnn Robinnnnn deleted the pato/profile-skeleton-loader branch April 26, 2024 17:32
@motzko
Copy link
Collaborator

motzko commented May 3, 2024

hey @pvicensSpacedev! think this PR caused a regression in my gallery https://gallery.so/motzko

the very first collection in this gallery is "hidden", and it seems like maybe hidden collections are being rendered permantly as skeleton loaders?

Screenshot 2024-05-02 at 9 38 12 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants