Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: pfp not working on mobile #2443

Merged
merged 2 commits into from
Apr 26, 2024
Merged

bug fix: pfp not working on mobile #2443

merged 2 commits into from
Apr 26, 2024

Conversation

Rohan-cp
Copy link
Collaborator

@Rohan-cp Rohan-cp commented Apr 26, 2024

Summary of Changes

update mobile logic to fetch pfp image URL to match that of web

Demo or Before/After Pics

Before After
IMG_2786 2 (1) Screenshot 2024-04-25 at 20 24 34

Edge Cases

List any common edge cases that you have considered and tested.

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 0:45am

@Rohan-cp Rohan-cp requested a review from Robinnnnn April 26, 2024 00:35
@Rohan-cp Rohan-cp marked this pull request as ready for review April 26, 2024 00:35
Copy link

Bundle Sizes

Compared against 19ff3a6

Route: No significant changes found

Dynamic import: No significant changes found

@Robinnnnn Robinnnnn merged commit b3705d8 into main Apr 26, 2024
8 of 9 checks passed
@Robinnnnn Robinnnnn deleted the rohan/fix-pfp branch April 26, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants