chore: Fix URL parameter concatenation #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodrigoDornelles
added a commit
that referenced
this pull request
Feb 25, 2025
* ci: docs workflow when modify samples or src * docs: written a little more * Update .gitattributes * fix: mustache precedence msdos filter * feat: support media on fengari driver html5 * merge (#144) * tests: dropped luaunit (#140) - #138 * feat: samples in very small screens 80x24 * feat: asteroids in screen <= 400 * feat: improve responsive menu asteroids * fix: self.params_dict is undefined #143 * fix: cleanup http native * fix: std accoplament error in http * style: fix luau linter --------- Co-authored-by: Finalshare90 <[email protected]> * feat: add support to fengari http module in html5 * chore: Fix URL parameter concatenation (#145) * tests: dropped luaunit (#140) - #138 * chore: Fix URL parameter concatenation --------- Co-authored-by: Finalshare90 <[email protected]> Co-authored-by: João Vicente <[email protected]> Co-authored-by: RodrigoDornelles <[email protected]> * feat: add support to json in html5 fengari * feat: start log system #14 * Add files via upload * fix: main entry in npm packages * fix: widescreen init html5 * ci: not allow non-ascii in codebase samples and src * feat: media.music mock.music mock.video * feat: add log system api to engine * docs: improve * docs: add example maze3d * docs: maze3d wolf_newmap and reference * change: read inteire file and split on build * feat: add flag --telemedia190 to build command * change: remove core repl from 'run' subcommand * feat: sync Ginga font size with HTML * fix: menu options order in asteroids * fix: remove current relative path in util fs * fix: custom dist on build * fix: dont create empty file cli fs.move * fix: mkdir in asset move * fix: mkdir in asset move * fix: luau-analyze warning media handler * feat: get enverioment [WIP] [0.0.20] * fix: icon32x32.bmp transparency in NDS * docs: write about std.draw * docs: add http in wget on README.md * feat: http force protocol * feat: optional fetch jsonrxi in fengari html5 * fix: transparenci in favicon.ico * fix: add protect to inexistent images * feat: add cache_set and cache_get --------- Co-authored-by: Finalshare90 <[email protected]> Co-authored-by: Joao Vicente <[email protected]> Co-authored-by: João Vicente <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed URL concatenation to add '?' only if parameters are present