Skip to content

Commit

Permalink
Fixed extension version upgrades (#147)
Browse files Browse the repository at this point in the history
This role no longer opens a VS Code window when upgrading an extension.

Fix: resolves #144
  • Loading branch information
freemanjp authored Feb 15, 2019
1 parent 96c366f commit 4f63e46
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion library/visual_studio_code_install_extension.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def install_extension(module, name):
before_ext_dirs = list_extension_dirs(module)
# Unfortunately `--force` suppresses errors (such as extension not found)
rc, out, err = module.run_command(
['code', '--install-extension', '--force', name])
['code', '--install-extension', name, '--force'])
# Whitelist: [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues.
if rc != 0 or (err and '[DEP0005]' not in err):
module.fail_json(
Expand Down

0 comments on commit 4f63e46

Please sign in to comment.