Add error message in IsIndecomposable for non-involutive solutions
#103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds an error message in the `IsIndecomposable` function when invoked with a non-involutive solution. It addresses the issue where the function previously triggered the generic error: `Error, Method for a property did not return true or false`.
…osable IsIndecomposable error message
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 110 110
Lines 106700 106700
=======================================
Hits 106261 106261
Misses 439 439
|
| @@ -774,7 +774,7 @@ InstallMethod(IsIndecomposable, | |||
| [ IsYB ], | |||
| function(obj) | |||
| if not IsInvolutive(obj) then | |||
| return fail; | |||
| Error("the solutions of the YBE is not involutive"); | |||
There was a problem hiding this comment.
Thank you @ilafly! Although, this text mixes plural and singular: "solutions ... is"
There was a problem hiding this comment.
It might be also nice to construct a test for this example - the CI complains that this is not covered by tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a specific error message in the
IsIndecomposablefunction when invoked with a non-involutive solution. Previously, the function triggered a generic error:Error, Method for a property did not return true or false.