Skip to content

Commit

Permalink
Minor tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
fingolfin committed Nov 30, 2023
1 parent 1af7a3e commit f8994e4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
9 changes: 4 additions & 5 deletions gap/matrix/classical.gi
Original file line number Diff line number Diff line change
Expand Up @@ -219,18 +219,17 @@ BindRecogMethod(FindHomMethodsClassical, "IsGeneric",
"tests whether group is generic",
function (recognise, grp)
if recognise.isGeneric = false then
return false;
return NeverApplicable;

Check warning on line 222 in gap/matrix/classical.gi

View check run for this annotation

Codecov / codecov/patch

gap/matrix/classical.gi#L222

Added line #L222 was not covered by tests
fi;

if Length(recognise.E) < 2 or
Length(recognise.LE) = 0 or
Length(recognise.BE) = 0 then
return fail;
return TemporaryFailure;
fi;

recognise.isGeneric := true;

return false;
return NeverApplicable;
end);

#enough info to rule out extension field groups...?
Expand Down Expand Up @@ -646,7 +645,7 @@ function(recognise, grp)
AddSet( recognise.porders, ord );
fi;

ppd := IsPpdElement (f, cpol, d, recognise.q, 1);
ppd := IsPpdElement (f, cpol, d, q, 1);
# if the element is no ppd we get out
if ppd = false then
recognise.isppd := false;
Expand Down
4 changes: 2 additions & 2 deletions gap/projective/tensor.gi
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
##
#############################################################################

RECOG.FindTensorKernel := function(ri,G,onlyone)
RECOG.FindTensorKernel := function(G,onlyone)
# Assume G respects a tensor product decomposition of its natural
# module V. Try to find the kernel of the canonical map:
local N,allps,c,fac,facs,i,j,kgens,newc,notused,o,pfacs,x,z;
Expand Down Expand Up @@ -339,7 +339,7 @@ function(ri,G)

# Now assume a tensor factorization exists:
#Gm := GroupWithMemory(G);???
N := RECOG.FindTensorKernel(ri,G,true);
N := RECOG.FindTensorKernel(G,true);
Info(InfoRecog,3,
"TensorDecomposable: I seem to have found a normal subgroup...");
r := RECOG.FindTensorDecomposition(G,N);
Expand Down

0 comments on commit f8994e4

Please sign in to comment.