Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gac is broken on HPC-GAP #1295

Closed
fingolfin opened this issue May 2, 2017 · 5 comments
Closed

gac is broken on HPC-GAP #1295

fingolfin opened this issue May 2, 2017 · 5 comments
Labels
kind: bug Issues describing general bugs, and PRs fixing them topic: HPC-GAP Issues and PRs related to HPC-GAP

Comments

@fingolfin
Copy link
Member

Right now, gac is broken for HPC-GAP. This is because it does not yet know what the correct CPPFLAGS are, specifically, that it should have -Ihpcgap before -I..

There might be other issues, though, I didn't try extensively. And of course just compiling a package for HPC-GAP won't make it work automatically, but it's of course an important first step.
@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them topic: HPC-GAP Issues and PRs related to HPC-GAP labels May 2, 2017
@fingolfin fingolfin mentioned this issue May 2, 2017
Merged
@fingolfin
Copy link
Member Author

Note: When fixing this, make sure to re-enable the gac test in etc/ci.sh which compiles edim (see PR #1292).

@fingolfin
Copy link
Member Author

This problem became simpler because there are no header files in hpcgap/src anymore. Still, we'd have to teach GAC to add -I flags for Boehm GC and libatomic.

@fingolfin fingolfin mentioned this issue Jun 22, 2017
Closed
@fingolfin
Copy link
Member Author

Also, gac should use ward when compiling kernel extensions, for the usual reasons.

@fingolfin
Copy link
Member Author

The first part of this should be resolved by PR #1906.

However, still no transparent use of ward. However, since ward currently is broken (see issue #1742), and we might move to a solution without it, this may not be necessary after all. Time will tell.

@fingolfin
Copy link
Member Author

Since ward was removed recently, I believe this is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug Issues describing general bugs, and PRs fixing them topic: HPC-GAP Issues and PRs related to HPC-GAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fingolfin