Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gac on HPC-GAP and re-enable edim (WIP, DO NOT MERGE) #1444

Closed
wants to merge 2 commits into from

Conversation

fingolfin
Copy link
Member

This is some work on getting gac to work for HPC-GAP, and to thus resolve issue #1295. Right now, it does not yet actually change gac, but at least it enables the test (namely, trying to build edim) which reveals this.

Help with this is welcome! :-).

@fingolfin fingolfin added do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) topic: HPC-GAP Issues and PRs related to HPC-GAP labels Jun 22, 2017
This can be useful for package build systems
This doesn't mean edim is actually usable (I haven't even tried it), but at
least it is one step closer to working.
@codecov
Copy link

codecov bot commented Sep 7, 2017

Codecov Report

Merging #1444 into master will decrease coverage by 3.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
- Coverage   64.42%   61.34%   -3.08%     
==========================================
  Files        1002      909      -93     
  Lines      326709   266419   -60290     
  Branches    13197    13514     +317     
==========================================
- Hits       210477   163434   -47043     
+ Misses     113363   100073   -13290     
- Partials     2869     2912      +43
Impacted Files Coverage Δ
extern/gmp/mpn/generic/gcdext_1.c 0% <0%> (-100%) ⬇️
extern/gmp/mpn/generic/toom_eval_dgr3_pm2.c 0% <0%> (-100%) ⬇️
extern/gmp/rand/randdef.c 0% <0%> (-100%) ⬇️
extern/gmp/mpn/generic/toom4_sqr.c 0% <0%> (-100%) ⬇️
extern/gmp/mpn/generic/toom_couple_handling.c 0% <0%> (-100%) ⬇️
...ern/gmp/mpn/generic/matrix22_mul1_inverse_vector.c 0% <0%> (-100%) ⬇️
extern/gmp/tal-reent.c 0% <0%> (-100%) ⬇️
extern/gmp/mpn/generic/toom33_mul.c 0% <0%> (-100%) ⬇️
extern/gmp/mpz/set_ui.c 0% <0%> (-100%) ⬇️
extern/gmp/mpn/generic/toom3_sqr.c 0% <0%> (-100%) ⬇️
... and 365 more

@fingolfin
Copy link
Member Author

I'll do this differently in a new PR.

@fingolfin fingolfin closed this Sep 9, 2017
@fingolfin fingolfin deleted the mh/edim branch May 17, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) topic: HPC-GAP Issues and PRs related to HPC-GAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant