GASMAN and kernel tweaks #2067
Merged
GASMAN and kernel tweaks #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
Codecov Report
@@ Coverage Diff @@
## master #2067 +/- ##
===========================================
- Coverage 67.03% 54.12% -12.92%
===========================================
Files 899 425 -474
Lines 273551 225018 -48533
===========================================
- Hits 183380 121785 -61595
- Misses 90171 103233 +13062
|
fingolfin
force-pushed
the
mh/gasman
branch
2 times, most recently
from
4b59e51 to
43a61ec
Compare
These checks, formerly controlled by * CHECK_FOR_CLASH_IN_INIT_SWEEP_FUNC, * DEBUG_HANDLER_REGISTRATION, * DEBUG_GLOBAL_BAGS, * DEBUG_LOADING, are cheap one-time costs, so there is no reason not to always activate them. Previously, by hiding them behind compile time flags, they were effectively never used by anybody.
This way, those debug outputs become much easier to enable (just pass `-D` to gap) and thus more helpful in practice.
ChrisJefferson
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into issue #1479 and the memory corruption in GASMAN, I enabled and enhanced various debug options, corrected comments, turned macros into functions etc. The resulting cleanup work is in this PR.
This already revealed a bug in the IO package (where a function cookie was incorrectly used twice).