Correctly return remaining data after parsing RESP array #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug in the
redis_reply:data/1
parser.If the redis server should return a reply array followed by any data (PONG in the example below), the
redis_reply
parser will incorrectly include PONG in the list of values, then finally return with a pending status.This results in
redis_client
(the calling process) ending up with a broken state that never sends back the replies.Applying this fix should return the correct values: