Remove the automatic conversion in string #10
+14
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rspec check all fields, i've removed the to_s, in order to validate the type (integer/string). It's actually a problem i've get into:
So to resolve this proble, i've just setup the possibility to verify if the type is set correctly by logstash (with a mutate, or even a simple json parse), so we can had better tests cases (and validate the type output, at least between integer and string).
The last thing i'll need to add/check, is if in the whole config, we don't have same entries with different type (and then a potential mapping conflict).