Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the automatic conversion in string #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

blackillzone
Copy link

When rspec check all fields, i've removed the to_s, in order to validate the type (integer/string). It's actually a problem i've get into:

  • My tests were all fine with the rspec
  • I've got a conflict of mapping in ElasticSearch, because i had the same entrie, but with different type (a pid in string and one in integer). The problem was one was automatically parse by the json plugin and set in integer, and the other was parsed by the kv plugin, and was set automatically in string type...

So to resolve this proble, i've just setup the possibility to verify if the type is set correctly by logstash (with a mutate, or even a simple json parse), so we can had better tests cases (and validate the type output, at least between integer and string).

The last thing i'll need to add/check, is if in the whole config, we don't have same entries with different type (and then a potential mapping conflict).

@blackillzone blackillzone mentioned this pull request Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant