This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Update Operator to support Gatekeeper v3.5.1 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Gatekeeper has fixed the kustomize build issues when using a go-getter URL reference, we can now simply run the make import-manifests target without the workaround of checking out Gatekeeper and building the Gatekeeper manifests from source.
This change now checks out the Gatekeeper repository and runs the bats e2e tests directly from the Gatekeeper repository instead of maintaining a duplicate version of the bats tests in the operator repository. This simplifies maintenance, and if it ever breaks, we can either revert back to committing the bats tests in the operator repo, or fixing it directly in the Gatekeeper version release branch.
We now rely on the bats e2e tests directly from the Gatekeeper repository. If this ever breaks, we can revert back to committing the bats e2e tests here, with any fixes necessary, or fix it in the Gatekeeper version release branch.
This update reorders and refactors the deletion and creation/updating of assets in the following order: 1. Delete the webhook configs. 2. Apply ordered assets i.e. not webhook configs. 3. Apply webhook configs. 4. Delete CRD configs. This ensures we avoid fatal errors caused by the deletion of CRDs prior to the deletion or updating of any webhooks and deployments.
This fixes occasional e2e test flakes where checking mutation is enabled was happening synchronously as soon as the Gatekeeper CR was created. This now modifies the check to be asynchronous using Eventually.
17 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #179
closes #158