Change blocks to be audited by their prior validator set #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of their posterior validator set. The prior validator set needs to be used by GRANDPA for validator set handover to work properly. Specifically, the first block in an epoch must be finalized by the previous validator set. This ensures that there is an unequivocal starting point for the next validator set, and there is no possibility of accidentally "unfinalizing" a block. The validator set used for auditing should match the set used by GRANDPA, as validators use auditing results to determine how they vote in GRANDPA. Hence the change to use the prior validator set for auditing.
alxmirap
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of their posterior validator set.
The prior validator set needs to be used by GRANDPA for validator set handover to work properly. Specifically, the first block in an epoch must be finalized by the previous validator set. This ensures that there is an unequivocal starting point for the next validator set, and there is no possibility of accidentally "unfinalizing" a block.
The validator set used for auditing should match the set used by GRANDPA, as validators use auditing results to determine how they vote in GRANDPA. Hence the change to use the prior validator set for auditing.