Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GZ_TOOLS_VER to 2 for consistency with rest of Garden and Harmonic libraries #391

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 2, 2023

🦟 Bug fix

All other Garden and Harmonic libraries install the auto-completion to share/gz/gz2.completion.d/, while gz-tools install them to share/gz/gz1.completion.d/, I guess this was just a typo/leftover.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@traversaro traversaro requested a review from caguero as a code owner October 2, 2023 09:31
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #391 (36c5ba9) into gz-msgs9 (ca9d66c) will not change coverage.
The diff coverage is n/a.

❗ Current head 36c5ba9 differs from pull request most recent head 690d2a6. Consider uploading reports for the commit 690d2a6 to get more accurate results

@@            Coverage Diff            @@
##           gz-msgs9     #391   +/-   ##
=========================================
  Coverage     95.57%   95.57%           
=========================================
  Files            10       10           
  Lines          1062     1062           
=========================================
  Hits           1015     1015           
  Misses           47       47           

@mjcarroll mjcarroll merged commit fac43a8 into gazebosim:gz-msgs9 Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants