Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous cleanups of protobuf generator plugin #405

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

mjcarroll
Copy link
Contributor

Removes some unused code and variables and fixes some style nits.

@mjcarroll mjcarroll requested a review from caguero as a code owner October 30, 2023 15:09
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #405 (bb2aab4) into gz-msgs10 (8021595) will increase coverage by 0.40%.
The diff coverage is 100.00%.

❗ Current head bb2aab4 differs from pull request most recent head 645d5e4. Consider uploading reports for the commit 645d5e4 to get more accurate results

@@              Coverage Diff              @@
##           gz-msgs10     #405      +/-   ##
=============================================
+ Coverage      97.26%   97.67%   +0.40%     
=============================================
  Files             27       27              
  Lines           1172     1163       -9     
=============================================
- Hits            1140     1136       -4     
+ Misses            32       27       -5     
Files Coverage Δ
core/generator/Generator.cc 100.00% <100.00%> (+7.35%) ⬆️

Base automatically changed from mjcarroll/generator_memory_leak to gz-msgs10 October 30, 2023 17:00
@mjcarroll mjcarroll merged commit 25759b6 into gz-msgs10 Oct 30, 2023
6 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/generator_misc branch October 30, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants