Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: Fix py_binary location #406

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Bazel: Fix py_binary location #406

merged 2 commits into from
Dec 11, 2023

Conversation

mjcarroll
Copy link
Contributor

No description provided.

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll requested a review from caguero as a code owner October 31, 2023 13:39
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 31, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b0b0f8) 95.57% compared to head (eea20a6) 95.57%.

❗ Current head eea20a6 differs from pull request most recent head 0ded002. Consider uploading reports for the commit 0ded002 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           gz-msgs9     #406   +/-   ##
=========================================
  Coverage     95.57%   95.57%           
=========================================
  Files            10       10           
  Lines          1062     1062           
=========================================
  Hits           1015     1015           
  Misses           47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey
Copy link
Contributor

azeey commented Oct 31, 2023

Does this need gazebosim/gz-bazel#63?

@mjcarroll
Copy link
Contributor Author

Yes, I'm in a chicken-and-egg situation, trying to untangle that a bit.

@mjcarroll mjcarroll self-assigned this Nov 3, 2023
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Copy link
Contributor Author

This one is now ready for review since gazebosim/gz-bazel#63 landed

@mjcarroll mjcarroll merged commit 29cfe33 into gz-msgs9 Dec 11, 2023
14 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/bazel_garden branch December 11, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants