Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations: tock #476

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Remove deprecations: tock #476

merged 6 commits into from
Dec 19, 2024

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Dec 4, 2024

🦟 Bug fix

Perform the tock of the tick-tock cycle and remove / move deprecated code.

@peci1

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <[email protected]>
Copy link
Contributor

@peci1 peci1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little suggestion, otherwise LGTM.

Migration.md Outdated Show resolved Hide resolved
Co-authored-by: Martin Pecka <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Copy link
Collaborator Author

caguero commented Dec 5, 2024

I need to check why Homebrew isn't happy.

Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero enabled auto-merge (squash) December 19, 2024 21:32
@caguero caguero disabled auto-merge December 19, 2024 21:33
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise, LGTM!

Migration.md Outdated Show resolved Hide resolved
Co-authored-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero merged commit 893be5b into main Dec 19, 2024
10 checks passed
@caguero caguero deleted the caguero/12_tock branch December 19, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants