-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows installation #71
Conversation
Signed-off-by: Mabel Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-sensors4 #71 +/- ##
=============================================
Coverage 76.01% 76.01%
=============================================
Files 23 23
Lines 2322 2322
=============================================
Hits 1765 1765
Misses 557 557 Continue to review full report at Codecov.
|
Signed-off-by: Mabel Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I agree with the usage of cmake
for building, it just feels a little over-complicated to have to manually specify the prefix path so that it can be linked. For sake of consistency among tutorials, I think it's good to use cmake
, perhaps we could just a note to optionally use colcon
on this one since a beginning user (and maybe even more advanced) may have difficult finding the correct path to link.
Install Ignition dependencies, replacing `<#>` with the desired versions: | ||
|
||
``` | ||
conda install libignition-cmake<#> libignition-common<#> libignition-math<#> libignition-transport<#> libignition-msgs<#> libignition-plugin<#> --channel conda-forge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, do we need to install libsdformat
?
Closing to retarget to Citadel. #82 |
Partially addresses gazebosim/docs#117
Made headings and code blocks consistent with other per-package installation tutorials.
One of the dependencies,
libignition-rendering
, is not yet on conda-forge and needs to be installed from source.libignition-sensors
is also not on conda-forge, so we don't have binary install instructions for Windows in this PR.Both libraries need to be added to conda-forge.