Stop server to reduce flakiness of UNIT_Server_TEST #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <[email protected]>
Passing test console output (from macOS) |
Failing test console output |
|
looks like a race condition. If the systems' PostUpdate thread started running, the test gets stuck shutting down. Maybe one thing to try is not load the scene_broadcaster system as it does not look like it's needed for this test (and probably need to change the expectation of system count to |
It would be nice if we could could fix the race condition though. |
Signed-off-by: Steve Peters <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-sim9 #2740 +/- ##
==========================================
Coverage ? 68.94%
==========================================
Files ? 345
Lines ? 33349
Branches ? 0
==========================================
Hits ? 22994
Misses ? 10355
Partials ? 0 ☔ View full report in Codecov by Sentry. |
scpeters
changed the title
Running test with thread sanitizer, like According to my observations, threads are stuck on a barrier, while rest of the code are starting destroying in the end of test and eventually it stuck in destructor, on thread join operation. Line number may be skewed(this log is a couple weeks old), but it's inside Still this bug has not the best reproducibility, sometimes executable should be restarted more than 100 times to reproduce hang |
scpeters
commented
Mar 5, 2025
| EXPECT_TRUE(executed); | ||
| EXPECT_TRUE(result); | ||
| EXPECT_EQ("TestSensorSystem", rep.data()); | ||
| server.Stop(); |
There was a problem hiding this comment.
I guess ~ServerPrivate is already calling Stop()
I'm not sure if this actually fixes anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #2609.
Summary
The
ServerRepeat/ServerFixture.ServerConfigSensorPlugin/0test was timing out flakily. This adds print statements and aserver->Stop();call to aid in shutdown.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.