-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch ros_gz_bridge from xml #550
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
* Launch file for the bridge Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
* Launch file for the bridge Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
* Launch file for the bridge Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
…_node_composition Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
config_file: SomeSubstitutionsType, | ||
container_name: SomeSubstitutionsType, | ||
namespace: SomeSubstitutionsType, | ||
use_composition: SomeSubstitutionsType, | ||
use_respawn: SomeSubstitutionsType, | ||
log_level: SomeSubstitutionsType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these parameters are optional in ros_gz_bridge.launch.py
right? Can we do the same here?
Here's an example: https://github.com/ros2/launch_ros/blob/2bf4e6057dea57669c19395f6f39d390bd420ee7/launch_ros/launch_ros/actions/node.py#L121-L129
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 0bfc81d.
ros_gz_sim/launch/ros_gz_sim.launch
Outdated
<gzserver | ||
world_sdf_file="$(var world_sdf_file)" | ||
world_sdf_string="$(var world_sdf_string)" | ||
container_name="$(var container_name)" | ||
use_composition="$(var use_composition)"> | ||
</gzserver> | ||
<ros_gz_bridge | ||
config_file="$(var config_file)" | ||
container_name="$(var container_name)" | ||
namespace="$(var namespace)" | ||
use_composition="$(var use_composition)" | ||
use_respawn="$(var use_respawn)" | ||
log_level="$(var log_level)"> | ||
</ros_gz_bridge> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice!! 🎉
Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
…s_gz into gz_sim_ros_node_composition
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Add gzserver with ability to load an SDF file or string Signed-off-by: Addisu Z. Taddese <[email protected]>
🎉 New feature
Part of #552
Summary
This patch allows to run the
ros_gz
bridge as an executable or as a composable node from an XML file.How to test it?
Use the provided
ros_gz_bridge.launch
(modifyconfig_file
accordingly) to run the bridge as an executableVerify that you see the
/ros_chatter
topic:And confirm that no container has been created:
Now
CTRL-C
the bridge and try the composable version:Verify that you see the
/ros_chatter
topic:And confirm that a container has been created:
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.