broker: tear down and restart a demoted replica #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ad2a8c9.
It's possible for a broker to transition from primary => replica, if it doesn't happen to observe a keyspace update where it's assignment is removed prior to it being re-added by the allocator. If we were the primary, we need to be sure to tear down the replication pipeline we may be holding. Handle this scenario by cancelling the current replica and building a new one. Also add a (hopefully) temporary work-around for the multiple assignment issue we're currently tracking down.
jgraettinger
force-pushed
the
johnny/release-pipeline
branch
from
e0f2f4a to
8d8fa04
Compare
It was previously possible for some Etcd transactions to be applied by Checkpoint within a converge() call, and for a failure to then cause converge() to bubble up an error, which could result in not reading through the preceeding successful transactions before continuing. Refactor checkpointTxn to retain the last successful transaction revision, and ensure we read through this revision regardless of whether the converge fully completed or failed along the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at making sure pipelines are released in this scenario.
Under this approach, we cancel the whole replica and build a new one, relying on the existing replica cancellation and shutdown behavior.
This change is