add --only-free and --help options to tests
#1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISSOtm
requested changes
Aug 17, 2023
Rangi42
added
enhancement
ISSOtm
requested changes
Aug 17, 2023
ISSOtm
previously requested changes
Aug 18, 2023
avivace
approved these changes
Aug 18, 2023
Rangi42
reviewed
Aug 18, 2023
Rangi42
reviewed
Aug 18, 2023
Rangi42
reviewed
Aug 18, 2023
Rangi42
reviewed
Aug 18, 2023
Rangi42
changed the title
--only-free and --help options to tests
Rangi42
reviewed
Aug 19, 2023
Rangi42
reviewed
Aug 19, 2023
Rangi42
reviewed
Aug 19, 2023
Rangi42
reviewed
Aug 19, 2023
|
Looks good to me! Again, just needs to squash the commits to get CI to pass. |
|
Bikeshedding time: if |
ISSOtm
approved these changes
Aug 20, 2023
Use getopt(1) to provide -h, --help, and --dfsg options in test/fetch-test-deps.sh and test/run-tests.sh - -h or --help prints a usage message - --dfsg skips repositories with non-free licenses (pokecrystal and pokered) in favor of ucity to support packaging RGBDS for Debian - --dfsg can be combined with --get-hash or --get-paths change --dfsg option to --only-free I was told the `+dfsg.1` used in Debian's repacks of upstream repos and tarballs that contain non-free software is too obscure. ISSOtm and Rangi42 suggested `--only-free` which carries no Debian baggage. https://www.reddit.com/r/debian/comments/66094l/what_is_dfsg_in_package_version_numbers/ - change --dfsg option to --only-free - temporarily enable logging (set -x) to troubleshoot build failure on macOS don't depend on util-linux getopt util-linux getopt has long option parsing functionality not available in macOS getopt. Instead, parse the options in pure Bash, treating each option as a separate word. remove tracing from test The removal of getopt indeed fixed test scripts on macOS. This means we no longer need set -x to trace execution. Co-authored-by: Eldred Habert <[email protected]> use true/false for booleans in test scripts I haven't had a chance to read the `bash(1)` manual cover to cover (reading 6600 lines in `less(1)` is an attention challenge to me) but it appears `true` and `false` are preferred because `true(1)` and `false(1)` run faster than `test(1)`, to which `[` is a link. Co-authored-by: Eldred Habert <[email protected]> act on stylistic nitpicks by Rangi42 - remove explanation of `set -e` even from run-tests.sh, which had previously included one - visually distinguish explanations of sections of a script from explanations of individual functions within a section - change variable names that refer to script names to match the capitalized default filename of the script minus any extension - change variable names that do not refer to script names to lowercase Apply suggestions from code review Co-authored-by: Rangi <[email protected]> remane with_nonfree variable in tests to nonfree per @Rangi42's preference
|
Rebased on top of current master to pull in CI fixes. |
|
Might be a good chance to fix the commit title and message. |
2 tasks
Rangi42
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
getopt(1)to provide-h,--help, and--dfsgoptions intest/fetch-test-deps.shandtest/run-tests.sh-hor--helpprints a usage message--dfsg(which stands for Debian Free Software Guidelines) skips repositories with non-free licenses (pokecrystalandpokered) in favor ofucityto support packaging RGBDS for Debian--dfsgcan be combined with--get-hashor--get-pathsFix #1160