Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip test on the sign of the wavecorr correction #80

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Conversation

gbrammer
Copy link
Owner

@gbrammer gbrammer commented Oct 22, 2024

The signs of source_xpos and dwave_step should be the same. The sign of the wavelength correction was incorrect in earlier versions of the jwst pipeline, perhaps jwst<=1.15. However, they're now correct in jwst==1.16.

Other changes here made to pass tests with jwst==1.16.

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 47.14286% with 37 lines in your changes missing coverage. Please review.

Project coverage is 67.20%. Comparing base (5b887ff) to head (95e8c2f).

Files with missing lines Patch % Lines
msaexp/slit_combine.py 15.78% 32 Missing ⚠️
msaexp/tests/test_utils.py 86.66% 2 Missing ⚠️
msaexp/tests/test_combine.py 75.00% 1 Missing ⚠️
msaexp/tests/test_drizzle.py 85.71% 1 Missing ⚠️
msaexp/tests/test_spectra.py 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   67.47%   67.20%   -0.27%     
==========================================
  Files          16       16              
  Lines        7092     7151      +59     
==========================================
+ Hits         4785     4806      +21     
- Misses       2307     2345      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbrammer gbrammer merged commit 71dfe82 into main Oct 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants