Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to group key #81

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Add filter to group key #81

merged 1 commit into from
Oct 23, 2024

Conversation

gbrammer
Copy link
Owner

Add blocking filter to key when combining spectra so that G140M-F070LP and G140M-F100LP aren't degenerate.

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.20%. Comparing base (71dfe82) to head (5a9faf9).

Files with missing lines Patch % Lines
msaexp/slit_combine.py 54.54% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files          16       16           
  Lines        7151     7151           
=======================================
  Hits         4806     4806           
  Misses       2345     2345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbrammer gbrammer merged commit 6c66890 into main Oct 23, 2024
10 checks passed
@gbrammer gbrammer deleted the split-grating-filter branch October 23, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants