Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exposure time accounting #90

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Fix exposure time accounting #90

merged 2 commits into from
Jan 20, 2025

Conversation

gbrammer
Copy link
Owner

The EXPTIME keyword of the spectra combined and extracted with slit_combine double counted the exposure times for cases with contributions from both NRS1 and NRS2 detectors. This update fixes the accounting.

Also includes updates to msaexp.cloud for passing additional keyword parameters stored in the database.

@gbrammer gbrammer merged commit c572440 into main Jan 20, 2025
10 checks passed
@gbrammer gbrammer deleted the fix-accounting branch January 20, 2025 15:20
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 51.43%. Comparing base (92b1aa6) to head (6ef71c2).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
msaexp/slit_combine.py 55.55% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   51.45%   51.43%   -0.03%     
==========================================
  Files          16       16              
  Lines        7851     7859       +8     
==========================================
+ Hits         4040     4042       +2     
- Misses       3811     3817       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant